fix: stop atkgen turn count variation in test relying on fixed turn count#1226
Merged
leondz merged 1 commit intoNVIDIA:mainfrom May 21, 2025
Merged
Conversation
…. if test.Repeat generator is used)
leondz
added
bug
jmartin-tech
approved these changes
May 21, 2025
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
This makes sense, thank you for tracking that down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
failure
see
cause identified
atkgenstopped early if target repeats itself. The chance of this happening is increased whentest.Repeatis the target, because this means attack model output becomes attack model input, creating a feedback loop. The early stopping behaviour meant transient test failures for tests counting activity withinatkgen.fix
test.Lipsumforatkgentesting